Help - Search - Members - Calendar
Full Version: Skype sidebar for Firefox overrides JS functions in HTML document
Skype Community > English > Skype products > Toolbars
lisandro_mc
I'm a bit tired after reporting this issue 3 times to the support team (automated answer never came) starting one week ago, then a further explanation, then being asked to post here.

If this is already reported, it's not my fault: this forum's search engine just doesn't work (nor seems to work the one in support).

I hope you can provide a quick fix to this issue.

Thanks in advance.


>>>>

I lost some hours debugging a weird error in a webpage I was developing, only
to find out that one of my functions was being overriden by your Skype extension.

Somehow encapsulation is broken; I don't know if this is normal behaviour in
Firefox addons, but I can't be changing my local functions' names after every
popular addon out there.

Overriding happens only after the document body has loaded.

I uploaded a testcase here: http://www.latdev.com.ar/skype/skype_addon.htm.

The source code of your addon JS is here:
http://www.latdev.com.ar/skype/injection_graph_func.js

Tested in Spanish, English and French.

Please let me know about this.

-----------------------------------------------------------------------

Skype Version: 3.2.0.175
Language: es
Browser: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.8.1.5)
Gecko/20070713 Firefox/2.0.0.5


>>>>


From: Lisandro Mc
Received: 1.08.2007 14:21:59 GMT Standard Time (GMT - 0:00 )
To: Katrin - Skype Support <support@skype.net>
Subject: Re: GQW: Skype extension for Firefox overrides JS functions in document

Hi Katrin,

I'm not really sure about what extra info you may be lacking regarding this
problem; to me it would seem to be neatly identified: your Skype addon overrides
existing functions in the loaded document. I even put up a testcase and the
source code of your addon at the time this problem happened. Or is this an
automated answer?

The testcase will serve you as comparison between normal behavior (without
addon), which shows "hello" both when you load the document and when you click on
it; and the altered one (with the addon loaded) that shows "hello" at loading
time but when you click on the document it shows "undefined" as the getBounds is
overriden by your addon's.

One possible way to avoid this problem is prefixing your addon JS functions
with something like "skype_" or giving it an enclosed namespace (for instance,
Skype.getBounds = function ... ).

By the time this happened I was using Firefox 2.0.0.5. The addon doesn't seem
to be compatible with the new Firefox 2.0.0.6. Anyway it would be a good idea to
fix this issue prior to releasing an updated addon version.

Looking forward to your reply.
Best,
Lisandro Mc Gough
Peter Kalmström
Hi Lisandro,
I apologize for the trouble - we have added this to our bug tracker and will fix it before the next FF add-on update.
Thanks for bringing this to our attention!
lisandro_mc
QUOTE(Peter Kalmström @ Mon Aug 6 2007, 13:40) [snapback]425506[/snapback]

Hi Lisandro,
I apologize for the trouble - we have added this to our bug tracker and will fix it before the next FF add-on update.
Thanks for bringing this to our attention!



Hi Peter,

I confirm that this bug still exists as of sidebar version 2.2.0.70 bundled with Skype version 3.5.0.239, tested on Firefox 2.0.0.9, WinXPSP2.

Would you please take care of this issue asap? It's breaking a public web service we have online.

Thanks again.

Lisandro Mc Gough
Peter Kalmström
Hi Lisandro,
Yes - it will be fixed soon. However - you might want to consider changing the javascript function names in the public web service you have online meanwhile. Even if we update tomorrow it will take many months before all users that have the Firefox extension installed have updated. :-(
Again, I do apologize for the trouble!
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.